Lower JDK version for modules not using ffm#708
Merged
ktoso merged 2 commits intoswiftlang:mainfrom Apr 17, 2026
Merged
Conversation
We accidentally required JDK25 in the build for no reason including for the core module. The bytecode is Java11, and we use JDK17 at least to build. We automatically detect JDK25, and if detected, we build the ffm modules as well. The FFM modules have ofc the expected higher JDK requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We accidentally required JDK25 in the build for no reason including for
the core module.
The bytecode is Java11, and we use JDK17 at least to build for
swiftKitCore.We automatically detect JDK25, and if detected, we build the ffm modules
as well. The FFM modules have ofc the expected higher JDK requirement.